X-Rcpt-Trace: gkrellm at lists.netservicesgroup.com
Received-SPF: none (Cache: No spf1 record for (srcbox.net) ) client-ip=188.40.129.132; envelope-from=<stefan+gkrellm@srcbox.net>; x-ip-name=box.srcbox.net;
X-Received: from box.srcbox.net (unverified [188.40.129.132])
by mailproc.sbbsnet.net (Network-Services-Group-Email) with ESMTP (TLS) id 1547776-1928206
for <gkrellm@lists.netservicesgroup.com>; Sun, 07 Oct 2018 07:45:32 -0400
X-Return-Path: stefan+gkrellm
X-Received: from [IPv6:2a04:4540:6c01:5f01:28af:94c0:ac87:39db] (unknown [IPv6:2a04:4540:6c01:5f01:28af:94c0:ac87:39db])
by box.srcbox.net (Postfix) with ESMTPSA id 95C6E47E06A5
for <gkrellm@lists.netservicesgroup.com>; Sun, 7 Oct 2018 13:45:30 +0200 (CEST)
Subject: Re: [Gkrellm] Error in krell scale for volume sizes in fs,c
To: gkrellm@lists.netservicesgroup.com
References: <4407357.lKIgZNIjDk@tommyiv>
From: Stefan Gehn
Message-ID: <e5768eb2-03d5-0c47-5486-209ecd67fb5b@srcbox.net>
Date: Sun, 7 Oct 2018 13:45:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <4407357.lKIgZNIjDk@tommyiv>
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
X-Originating-IP: 188.40.129.132
X-Country: code=DE country="Germany" ip=188.40.129.132
X-Rcpt-To: <gkrellm@lists.netservicesgroup.com>
X-SpamDetect: *********: 9.0 sd=9.0 Close nspam=1 nok=0 1.00 0.90(X-Phrase:isspam) 0.42(X-Verify-Helo:+OK) $0.46(StandardTLD) $0.48(X-LangGuess:English) 0.50(X-myrbl:Color=blue) NotSaned 7.1 9.0
X-NotAscii: charset=windows-1252
X-LangGuess: English
X-Phrase: IsSpam score=1.00
X-Verify-Helo: +OK box.srcbox.net
X-Encryption: SSL encrypted
X-MyRbl: Color=Blue (rbl) Age=0 Spam=0 Notspam=0 Stars=0 Good=2 Friend=0 Surbl=0 Catch=0 r=0 ip=188.40.129.132
X-IP-stats: Incoming Outgoing Last 0, First 68, in=112, out=2, spam=0 Known=true ip=188.40.129.132
List-Unsubscribe: <mailto:gkrellm-leave@lists.netservicesgroup.com?subject=unsubscribe>
X-Mailing-List: gkrellm@lists.netservicesgroup.com
List-ID: <gkrellm@lists.netservicesgroup.com>
Precedence: bulk
Reply-To: gkrellm@lists.netservicesgroup.com
Hi Peter,
On 30/07/2018 15:01, Peter Hyman wrote:
> gkrellm krell scale for volume sizes is at 100% in some cases. See graphic.
> This issue appeared after creating some LVM volumes.
>
> This patch addresses two issues:
> 1. changes long long type to unsigned long long since disk block size is always positive.
This would also need type changes for other variables otherwise you're
comparing values of different signedness which triggers compiler
warnings, hence I've left that out for now.
> 2. corrects fs_>krell_factor when blocks > 2097152
Indeed, the original code before commit
14c4cc4ba0cc717a09b0d9a8390787c5c726e63f used a scale factor of 1024 for
that block size. I restored the correct scale factor now, thanks for the
fix.
Regards,
Stefan
|